[Build] Add Github workflows #9510
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9510 +/- ##
=======================================
Coverage 58.57% 58.57%
=======================================
Files 386 386
Lines 12287 12287
Branches 3025 3025
=======================================
Hits 7197 7197
Misses 4906 4906
Partials 184 184 Continue to review full report at Codecov.
|
ktmud
force-pushed
the
github-actions
branch
2 times, most recently
from
1fab574 to
b008f58
Compare
as replacement to Travis CI.
|
@ktmud seems like travis doesn't like your PRs, the hooks don't seem to be registering with github. I think you're the only one experiencing this now 🤔 |
|
Here's the successful build but it didn't register with github. https://travis-ci.org/github/apache/incubator-superset/builds/673991032 |
|
Looks like it still won't pass after I close & reopened the PR. |
|
Gonna close and recreate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #9490 after some major refactoring.
CATEGORY
SUMMARY
Adding GitHub Actions per discussion in #9481 . This is a pure addition to the current build process for now. Nothing changed for Travis CI, except Cypress was upgraded from
3.6.1to4.3.0. We could evaluate whether to disable Travis CI once these GitHub Actions become more stable.Jobs are split into 4 workflows to maximize parallelization:
A custom GitHub Action was created to generalize the building steps related to caching and dependencies.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Once successfully integrated, GitHub PRs should have checks like below:
Meanwhile, use ktmud#27 to see these checks in action.
TEST PLAN
Make sure CI passes.
ADDITIONAL INFORMATION
N/A
REVIEWERS
@john-bodley @dpgaspar @mistercrunch @craig-rueda