Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #9731

Merged
merged 2 commits into from
May 6, 2020
Merged

Update README.md #9731

merged 2 commits into from
May 6, 2020

Conversation

ceohockey60
Copy link
Contributor

Update and reorganize README to make it easier to navigate and use for community visitors.

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • [ x ] Documentation

SUMMARY

Update and reorganize the README with better navigation and headline anchors to make it easier to navigate and use for community visitors. Also updated most Superset company user with the github handle of the person who filed the initial PR to give proper recognition.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

Update and reorganize README to make it easier to navigate and use for community visitors.
@request-info
Copy link

request-info bot commented May 4, 2020

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label May 4, 2020
@codecov-io
Copy link

codecov-io commented May 4, 2020

Codecov Report

Merging #9731 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9731      +/-   ##
==========================================
+ Coverage   70.49%   70.51%   +0.02%     
==========================================
  Files         402      402              
  Lines       12564    12564              
  Branches     3112     3112              
==========================================
+ Hits         8857     8860       +3     
+ Misses       3593     3590       -3     
  Partials      114      114              
Flag Coverage Δ
#cypress 53.65% <ø> (+0.07%) ⬆️
#javascript 58.90% <ø> (ø)
Impacted Files Coverage Δ
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 72.72% <0.00%> (+6.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865a909...a0b3d72. Read the comment docs.

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, good improvements, but let's get rid of the horizontal bars.

See it rendered here in your branch: https://github.com/ceohockey60/incubator-superset/tree/patch-1

@mistercrunch
Copy link
Member

oh and master was broken earlier today :(

rebase

@mistercrunch mistercrunch merged commit d59e50f into apache:master May 6, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:more-info Requires more information from author size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants