Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the builtin calendar control panel #9771

Merged
merged 1 commit into from
May 8, 2020

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented May 8, 2020

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

The Calendar plugin got its own control panel config in apache-superset/superset-ui#432, so we use that now

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@rusackas @pkdotson @kristw

@codecov-io
Copy link

codecov-io commented May 8, 2020

Codecov Report

Merging #9771 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9771      +/-   ##
==========================================
- Coverage   70.81%   70.79%   -0.02%     
==========================================
  Files         586      586              
  Lines       30443    30442       -1     
  Branches     3120     3120              
==========================================
- Hits        21558    21552       -6     
- Misses       8771     8775       +4     
- Partials      114      115       +1     
Flag Coverage Δ
#cypress 53.63% <ø> (-0.10%) ⬇️
#javascript 59.07% <ø> (+<0.01%) ⬆️
#python 70.93% <ø> (ø)
Impacted Files Coverage Δ
superset-frontend/src/setup/setupPlugins.ts 8.00% <ø> (+0.15%) ⬆️
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 66.15% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a49c69...2166d91. Read the comment docs.

@rusackas rusackas merged commit 3a21391 into apache:master May 8, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.37.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants