Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Excel file export #9924

Closed
wants to merge 2 commits into from
Closed

Conversation

blcksrx
Copy link

@blcksrx blcksrx commented May 27, 2020

SUMMARY

Support excel for exporting

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot from 2020-05-27 12-57-02
Screenshot from 2020-05-27 12-56-17
Screenshot from 2020-05-27 12-55-50

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #9924 into master will decrease coverage by 1.45%.
The diff coverage is 80.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9924      +/-   ##
==========================================
- Coverage   71.22%   69.77%   -1.46%     
==========================================
  Files         585      184     -401     
  Lines       30828    18257   -12571     
  Branches     3237        0    -3237     
==========================================
- Hits        21957    12738    -9219     
+ Misses       8762     5519    -3243     
+ Partials      109        0     -109     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 69.77% <80.75%> (-1.64%) ⬇️
Impacted Files Coverage Δ
superset/charts/schemas.py 100.00% <ø> (ø)
superset/sql_validators/presto_db.py 82.89% <ø> (ø)
superset/views/base_schemas.py 0.00% <0.00%> (ø)
superset/viz_sip38.py 0.00% <0.00%> (ø)
...uperset/utils/dashboard_filter_scopes_converter.py 34.04% <22.22%> (ø)
superset/jinja_context.py 80.95% <43.75%> (-4.77%) ⬇️
superset/db_engine_specs/pinot.py 67.56% <57.14%> (+9.03%) ⬆️
superset/viz.py 56.99% <66.66%> (-14.99%) ⬇️
superset/utils/dict_import_export.py 55.81% <71.42%> (-0.60%) ⬇️
superset/charts/api.py 80.31% <73.68%> (-1.61%) ⬇️
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9edfc8f...a116941. Read the comment docs.

@blcksrx blcksrx force-pushed the excel_file_export branch from 438ab2e to a116941 Compare May 27, 2020 09:08
@blcksrx
Copy link
Author

blcksrx commented May 27, 2020

@villebro

@blcksrx blcksrx force-pushed the excel_file_export branch from 17c08eb to a116941 Compare June 7, 2020 09:13
@AmirDadkhah1996 AmirDadkhah1996 force-pushed the excel_file_export branch 2 times, most recently from 0765eba to 92e89ce Compare June 9, 2020 14:14
@bkyryliuk
Copy link
Member

just a general comment - it would be nice to fix CI first.

@bkyryliuk
Copy link
Member

@blcksrx - could you share more about this feature use case and why .csv is not good enough? e.g. excel supports csv files as well as I know

@rusackas
Copy link
Member

Pulling over a comment from a Slack discussion:

I would say it's worth embracing the growth of additional save/export options with a dropdown menu, e.g.:

+------------------------+
| Export Data To...  | ▼ |
+------------------------+
| Clipboard              |
| CSV                    |
| Excel                  |
| Parquet                |
| Google Sheet           |
+------------------------+

... to avoid button proliferation and add a spot for future integrations.

@blcksrx blcksrx force-pushed the excel_file_export branch from d096dcb to a116941 Compare June 26, 2020 19:58
@blcksrx blcksrx force-pushed the excel_file_export branch from a116941 to f061166 Compare June 26, 2020 20:05
@blcksrx blcksrx force-pushed the excel_file_export branch 2 times, most recently from 6519d3b to a116941 Compare June 26, 2020 21:06
@blcksrx blcksrx force-pushed the excel_file_export branch 3 times, most recently from d5ed4b4 to 6ef5383 Compare July 3, 2020 20:55
@blcksrx blcksrx force-pushed the excel_file_export branch from 6ef5383 to 820319d Compare July 19, 2020 16:29
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Oct 4, 2020
@opus-42
Copy link
Contributor

opus-42 commented Oct 5, 2020

Hello @bkyryliuk. I have provided additional context on why this may be useful
#11162.

Not every user may be CSV-friendly users. Excel Export are easier to handle for those users. For me, this is about Superset being more accessible to generic users.

This feature would be really helpful in production

@stale stale bot removed the inactive Inactive for >= 30 days label Oct 5, 2020
@ninad-casebook
Copy link

One additional use-case for Excel over CSV is that datetime formats are not preserved in CSV. If the data being exported contains several datetime columns, then since CSV does not store date formatting this data is lost.

@blcksrx blcksrx closed this Oct 24, 2020
@blcksrx blcksrx deleted the excel_file_export branch October 24, 2020 06:18
@arojoal
Copy link

arojoal commented Jun 22, 2021

I would like to know why finally this is not included into Superset. Here you can read a very good explanation of the importance of this feature for end users.
https://medium.com/geekculture/apache-superset-export-data-to-excel-38b8170a30ee

@blcksrx
Copy link
Author

blcksrx commented Jun 23, 2021

Actually Im frustrated about this, I made PRs two time about it, but after a while nobody did pay attention

@timnick-snow
Copy link

export-data-to-excel

@niyouzhu
Copy link

we need exporting as excel. it's common.

1 similar comment
@lukoou3
Copy link

lukoou3 commented Mar 4, 2023

we need exporting as excel. it's common.

@Habeeb556
Copy link
Contributor

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.