[SYSTEMDS-3273] Federated Timeout #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two things to the federated handler. 1. A timeout (default unlimited) that is enabled for tests to ensure that the tests finish instead of having a controller waiting infinitely on a crashed worker. 2. Log output of errors on the workers to enable debugging if you have access to the worker process output. This ensures that if there is sensitive information in the error message it is contained to the worker but still logged. 3. config file overwrite scratch_space if non existing in config file for tests. This is a bug where if the config file used by the test does not contain the scratch_space location it will use default, making it a race condition between parallel tests to create and delete the same scratch_space locations.
Baunsgaard
force-pushed
the
FederatedTimeOut
branch
from
cf87a95 to
fbdca4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two things to the federated handler.
ensure that the tests finish instead of having a controller waiting
infinitely on a crashed worker.
access to the worker process output. This ensures that if there is sensitive
information in the error message it is contained to the worker but still
logged.