-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYSTEMDS-3540] Check columns for One-Hot-Encoding before compression #2054
Open
smyomous
wants to merge
16
commits into
apache:main
Choose a base branch
from
smyomous:branch_backup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first commit
Add more logic
…into branch_backup
Baunsgaard
reviewed
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall good, however, some cleanup tasks left and we need to fix the tests.
src/main/java/org/apache/sysds/runtime/compress/estim/CompressedSizeInfo.java
Show resolved
Hide resolved
Simply, mark the comments as resolved if you have addressed them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SYSTEMDS-3540] Checking if column groups are One-Hot-Encoded before compression
This patch adds checks on column groups to verify if multiple columns, together, are One Hot Encoded. In that case, these column groups are compressed accordingly into an IdentityDictionary to exploit the structure of One Hot Encoded columns and optimize the subsequent operations. We observe a reduction in the number of column groups of up to 98%, with most experiments seeing a reduction of over 80%. However, the overhead on execution time is large for larger datasets due to the current implementation of the compression of One-Hot-Encoded columns.
Detailed documentation can be found in scripts/perftest/ohe_checks/README.md