[MINOR] Improve Compressed Binary Cell Ops #2083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
============================================
+ Coverage 70.50% 70.66% +0.15%
- Complexity 42071 42221 +150
============================================
Files 1441 1441
Lines 162297 162417 +120
Branches 31626 31654 +28
============================================
+ Hits 114425 114764 +339
+ Misses 38832 38663 -169
+ Partials 9040 8990 -50 ☔ View full report in Codecov by Sentry. |
This commit improves the test coverage of the compressed binary cell operation in this process it unearthed a few edge cases that produced wrong results in sparse inputs, and if performing overlapping constant minus vector. While making the PR I also include 100% coverage of our ternary operator. Overall this commit improve the code coverage by .1 % in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.