Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] CLA LMM Selection Multiply and Identity Multiply #2084

Closed
wants to merge 3 commits into from

Conversation

Baunsgaard
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 93.92813% with 49 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (49acf28) to head (c239149).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...e/sysds/runtime/compress/lib/CLALibLeftMultBy.java 97.02% 4 Missing and 5 partials ⚠️
...e/sysds/runtime/compress/colgroup/ColGroupOLE.java 0.00% 5 Missing ⚠️
...time/compress/colgroup/ColGroupSDCSingleZeros.java 44.44% 2 Missing and 3 partials ⚠️
...ds/runtime/compress/colgroup/ColGroupSDCZeros.java 81.48% 2 Missing and 3 partials ⚠️
...s/colgroup/dictionary/IdentityDictionarySlice.java 85.18% 2 Missing and 2 partials ⚠️
...e/sysds/runtime/compress/colgroup/ColGroupRLE.java 40.00% 2 Missing and 1 partial ⚠️
...e/sysds/runtime/compress/colgroup/ColGroupSDC.java 90.32% 2 Missing and 1 partial ⚠️
...me/compress/colgroup/ColGroupLinearFunctional.java 0.00% 2 Missing ⚠️
...ntime/compress/colgroup/dictionary/Dictionary.java 0.00% 2 Missing ⚠️
...mpress/colgroup/dictionary/IdentityDictionary.java 91.66% 1 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2084      +/-   ##
============================================
+ Coverage     70.62%   70.86%   +0.23%     
- Complexity    42209    42894     +685     
============================================
  Files          1442     1446       +4     
  Lines        162418   164094    +1676     
  Branches      31654    32006     +352     
============================================
+ Hits         114715   116285    +1570     
+ Misses        38711    38683      -28     
- Partials       8992     9126     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit contains the implementation details on
LLM refinements for supporting the new Identity dictionaries,
that remove the need for many of the matrix multiplications.

Furthermore it also contains the implementation details and optimizations
for selective Matrix Multiplications of matrices in the left side
containing only a single 1 in each row. The implementation there
simply decompress the rows associated with the 1, making the overall
compressed operation very efficient.

The overall implementation further improves the code-coverage of the
project by 0.24%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant