Skip to content

Conversation

@deroneriksson
Copy link
Member

Adds SystemML.py to the root of all artifacts where it makes sense.

@niketanpansare
Copy link
Contributor

@deroneriksson Since SystemML.py is likely going to be replace by a package structure once #197 is merged in, can you please hold off this PR ? Once the PR 197 is merged, we will have a seperate Python package artifact (as a tar file).

@deroneriksson
Copy link
Member Author

@niketanpansare @dusenberrymw
There is going to be another artifact added to the project devoted to Python? Shouldn't this be packaged with the regular jar and standalone tar.gz/zip?

@deroneriksson
Copy link
Member Author

@niketanpansare @dusenberrymw
BTW I am fine with whatever approach you believe to be the best approach for Python users. If you think this PR should be closed w/o merging, that is fine. :-)

@niketanpansare
Copy link
Contributor

The shell script in the python package 'uploadToPyPI.sh' will create a tar.gz in dist/ directory. We can add that artifact into our release. Anyone can use command 'pip install ..tar.gz' and install SystemML.

@deroneriksson
Copy link
Member Author

It's probably a good idea to keep @lresende aware of the status of this to be sure that the release will follow Apache requirements.

@niketanpansare
Copy link
Contributor

I have created a JIRA: https://issues.apache.org/jira/browse/SYSTEMML-883

@lresende or @deroneriksson Do either one of you want to take it over ?

@deroneriksson
Copy link
Member Author

@niketanpansare I'm probably not a good choice for most Python tasks due to my lack of experience with it. :-)
Should I go ahead and close this PR?

@niketanpansare
Copy link
Contributor

No worries :) ... I think we should not release the old SystemML.py (as it is deprecated) and only release the new Python package. Let's go ahead and close this PR.

@lresende commented on the JIRA that he will take a pass at this. If necessary, I too can help with it.

@deroneriksson
Copy link
Member Author

I will close this PR and the accompanying JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants