[SYSTEMDS-3912] Add resettable mode to LocalTaskQueue for efficient block reuse #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements resettable mode for TaskQueue allowing multiple consumers to iterate over the same blocks without removal, reducing reloads: - Add _resettable and _readPosition fields - Add setResettable() method to enable/disable resettable mode - Add resetIterator() method to restart iteration from beginning - Modify dequeueTask() to read without removing in resettable mode - Update toString() to show resettable state and position Benefits: - Prevents repeated disk reloads for multiple operations - Keeps blocks in memory for reuse until explicit cleanup - Backward compatible (default behavior unchanged) - Reduces memory eviction issues for shared data 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Hi @VirenS13117 -- this ticket SYSTEMDS-3912 is part of my master's project, I'm running experiments to guide this design and the changes may not be straightforward. (AI claude can't run the real experiments! 🤞 yet to guide our design) Let's find a feature you would like to work on. please mail us on dev@systemds.apache.org email list by subscribing to email list: https://systemds.apache.org/community |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables multiple operations to iterate over the same data blocks without removal, preventing costly disk reloads. When setResettable(true) is called, dequeueTask() reads without removing blocks,
allowing resetIterator() to restart from beginning. Maintains full backward compatibility with existing FIFO behavior when resettable mode is disabled.