[SYSTEMML-1325] Bugfix for GPU memory manager clear temporary memory #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Fixes bug in GPU cleanup with JMLC.
|
Looks good to me. Thanks @thomas9t 👍 |
src/main/java/org/apache/sysml/runtime/instructions/gpu/context/GPUMatrixMemoryManager.java
Show resolved
Hide resolved
|
@niketanpansare - anything else we need to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
GPUMemoryManager.clearTemporaryMemory()we deallocate pointers but do not set the correspondingPointerslots tonullin the associatedGPUObjectinstances. This can lead to attempted double-freeing of Pointers which results in an exception. This PR fixes this issue by creating a list of GPU objects associated with Pointers that have been freed as part ofclearTemporaryMemory()and setting the corresponding pointer slots tonull. This PR also addresses a minor issue with cleanup in JMLC which was causing Pointers for pinned data to be improperly cleared. Note this PR will reduce performance ofGPUMemoryManager.clearTemporaryMemory()because it is now necessary to search through the list of managedGPUObjectsto find the ones corresponding to pointers being freed. However, this method is only called once at the end of script invocation and so the performance cost will be small.@niketanpansare can you please take a look and let me know what you think?