Run Button is Enabled When an Operator is Unconfigured

[shengquan-ni]

The Run button now appears blue when an operator with required fields is unconfigured (i.e., required fields are not filled)

[AnzhiZhang]

There are two parts of this issue.

Button Not Updated After Validation

We can see from the screenshot also, by reproducing this issue, the operator appears red, but the button still shows valid.

This section handles workflow validation and posts errors to workflowValidationErrorStream

texera/core/gui/src/app/workspace/service/validation/validation-workflow.service.ts

Lines 137 to 145 in c7fcd9f

	private updateValidationState(operatorID: string, validation: Validation) {
	this.operatorValidationStream.next({ validation, operatorID });
	if (!validation.isValid) {
	this.workflowErrors[operatorID] = validation;
	} else {
	delete this.workflowErrors[operatorID];
	this.workflowValidationErrorStream.next({ errors: this.workflowErrors, workflowEmpty: this.workflowEmpty });
	}
	}

workflowValidationErrorStream is subscribed here

texera/core/gui/src/app/workspace/component/menu/menu.component.ts

Lines 178 to 186 in c7fcd9f

	// set the map of operatorStatusMap
	this.validationWorkflowService
	.getWorkflowValidationErrorStream()
	.pipe(untilDestroyed(this))
	.subscribe(value => {
	this.isWorkflowEmpty = value.workflowEmpty;
	this.isWorkflowValid = Object.keys(value.errors).length === 0;
	this.applyRunButtonBehavior(this.getRunButtonBehavior());
	});

The message will be posted only when the workflow validation result is valid.

required in JSON Schema Does Not Apply to Empty String in Frontend Validation

We are using Ajv in the frontend to validate JSON schema.

This is the JSON schema of BarChartOpDesc.

JSON Schema

{
  "$schema" : "http://json-schema.org/draft-07/schema#",
  "type" : "object",
  "additionalProperties" : false,
  "attributeTypeRules" : {
    "value" : {
      "enum" : [ "integer", "long", "double" ]
    }
  },
  "properties" : {
    "dummyPropertyList" : {
      "propertyOrder" : 1,
      "nullable" : true,
      "type" : "array",
      "items" : {
        "$ref" : "#/definitions/DummyProperties"
      },
      "description" : "Add dummy property if needed",
      "title" : "Dummy Property List"
    },
    "fields" : {
      "propertyOrder" : 4,
      "type" : "string",
      "description" : "Visualize categorical data in a Bar Chart",
      "title" : "Fields",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "categoryColumn" : {
      "propertyOrder" : 5,
      "nullable" : true,
      "type" : "string",
      "default" : "No Selection",
      "description" : "Optional - Select a column to Color Code the Categories",
      "title" : "Category Column",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "horizontalOrientation" : {
      "propertyOrder" : 6,
      "type" : "boolean",
      "default" : false,
      "description" : "Orientation Style",
      "title" : "Horizontal Orientation"
    },
    "pattern" : {
      "propertyOrder" : 7,
      "nullable" : true,
      "type" : "string",
      "description" : "Add texture to the chart based on an attribute",
      "title" : "Pattern",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "value" : {
      "propertyOrder" : 10,
      "type" : "string",
      "description" : "The value associated with each category",
      "title" : "Value Column",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    }
  },
  "required" : [ "fields", "horizontalOrientation", "value" ],
  "options" : {
    "multiple_editor_select_via_property" : {
      "property" : "operatorType",
      "value" : "BarChart"
    }
  },
  "definitions" : {
    "DummyProperties" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "dummyProperty" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "string",
          "title" : "Dummy Property"
        },
        "dummyValue" : {
          "propertyOrder" : 2,
          "nullable" : true,
          "type" : "string",
          "title" : "Dummy Value"
        }
      }
    },
    "PortDescription" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "portID" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "string",
          "title" : "Port ID"
        },
        "displayName" : {
          "propertyOrder" : 2,
          "nullable" : true,
          "type" : "string",
          "title" : "Display Name"
        },
        "allowMultiInputs" : {
          "propertyOrder" : 3,
          "type" : "boolean",
          "title" : "Allow Multi Inputs"
        },
        "isDynamicPort" : {
          "propertyOrder" : 4,
          "type" : "boolean",
          "title" : "Is Dynamic Port"
        },
        "partitionRequirement" : {
          "propertyOrder" : 5,
          "nullable" : true,
          "oneOf" : [ {
            "$ref" : "#/definitions/HashPartition"
          }, {
            "$ref" : "#/definitions/RangePartition"
          }, {
            "$ref" : "#/definitions/SinglePartition"
          }, {
            "$ref" : "#/definitions/BroadcastPartition"
          }, {
            "$ref" : "#/definitions/UnknownPartition"
          } ],
          "title" : "Partition Requirement"
        },
        "dependencies" : {
          "propertyOrder" : 6,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "$ref" : "#/definitions/Object"
          },
          "title" : "Dependencies"
        }
      },
      "required" : [ "allowMultiInputs", "isDynamicPort" ]
    },
    "HashPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "hash" ],
          "default" : "hash",
          "options" : {
            "hidden" : true
          }
        },
        "hashAttributeNames" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "type" : "string"
          },
          "title" : "Hash Attribute Names"
        }
      },
      "title" : "hash",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "hash"
        }
      }
    },
    "RangePartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "range" ],
          "default" : "range",
          "options" : {
            "hidden" : true
          }
        },
        "rangeAttributeNames" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "type" : "string"
          },
          "title" : "Range Attribute Names"
        },
        "rangeMin" : {
          "propertyOrder" : 2,
          "type" : "integer",
          "title" : "Range Min"
        },
        "rangeMax" : {
          "propertyOrder" : 3,
          "type" : "integer",
          "title" : "Range Max"
        }
      },
      "title" : "range",
      "required" : [ "type", "rangeMin", "rangeMax" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "range"
        }
      }
    },
    "SinglePartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "single" ],
          "default" : "single",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "single",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "single"
        }
      }
    },
    "BroadcastPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "broadcast" ],
          "default" : "broadcast",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "broadcast",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "broadcast"
        }
      }
    },
    "UnknownPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "none" ],
          "default" : "none",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "none",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "none"
        }
      }
    },
    "Object" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : { }
    }
  }
}

Required fields are included in the required list. However, if we test this schema in the frontend (a simple example).

import Ajv from "ajv";

const ajv = new Ajv({ allErrors: true, strict: false });
const schema = {
  type: "object",
  properties: {
    test: {
      type: "string",
    },
  },
  required: ["test"],
};

const json = {
  test: "",
};

// true
console.log(ajv.validate(schema, json));

const json2 = {};

// false
console.log(ajv.validate(schema, json2));

It only works for a real null property, not an empty string.

The debug information confirms this finding.

We will need to add @NotNull annotation from javax.validation.constraints.NotNull to introduce "minLength" : 1, requirement to the JSON Schema.

@JsonProperty(value = "value", required = true)
@JsonSchemaTitle("Value Column")
@JsonPropertyDescription("The value associated with each category")
@AutofillAttributeName
@NotNull(message = "Value column cannot be empty")
var value: String = ""

New JSON Schema

{
  "$schema" : "http://json-schema.org/draft-07/schema#",
  "type" : "object",
  "additionalProperties" : false,
  "attributeTypeRules" : {
    "value" : {
      "enum" : [ "integer", "long", "double" ]
    }
  },
  "properties" : {
    "dummyPropertyList" : {
      "propertyOrder" : 1,
      "nullable" : true,
      "type" : "array",
      "items" : {
        "$ref" : "#/definitions/DummyProperties"
      },
      "description" : "Add dummy property if needed",
      "title" : "Dummy Property List"
    },
    "fields" : {
      "propertyOrder" : 4,
      "type" : "string",
      "minLength" : 1,
      "description" : "Visualize categorical data in a Bar Chart",
      "title" : "Fields",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "categoryColumn" : {
      "propertyOrder" : 5,
      "type" : "string",
      "default" : "No Selection",
      "minLength" : 1,
      "description" : "Optional - Select a column to Color Code the Categories",
      "title" : "Category Column",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "horizontalOrientation" : {
      "propertyOrder" : 6,
      "type" : "boolean",
      "default" : false,
      "description" : "Orientation Style",
      "title" : "Horizontal Orientation"
    },
    "pattern" : {
      "propertyOrder" : 7,
      "type" : "string",
      "minLength" : 1,
      "description" : "Add texture to the chart based on an attribute",
      "title" : "Pattern",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    },
    "value" : {
      "propertyOrder" : 10,
      "type" : "string",
      "minLength" : 1,
      "description" : "The value associated with each category",
      "title" : "Value Column",
      "autofill" : "attributeName",
      "autofillAttributeOnPort" : 0
    }
  },
  "required" : [ "fields", "categoryColumn", "horizontalOrientation", "pattern", "value" ],
  "options" : {
    "multiple_editor_select_via_property" : {
      "property" : "operatorType",
      "value" : "BarChart"
    }
  },
  "definitions" : {
    "DummyProperties" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "dummyProperty" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "string",
          "title" : "Dummy Property"
        },
        "dummyValue" : {
          "propertyOrder" : 2,
          "nullable" : true,
          "type" : "string",
          "title" : "Dummy Value"
        }
      }
    },
    "PortDescription" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "portID" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "string",
          "title" : "Port ID"
        },
        "displayName" : {
          "propertyOrder" : 2,
          "nullable" : true,
          "type" : "string",
          "title" : "Display Name"
        },
        "allowMultiInputs" : {
          "propertyOrder" : 3,
          "type" : "boolean",
          "title" : "Allow Multi Inputs"
        },
        "isDynamicPort" : {
          "propertyOrder" : 4,
          "type" : "boolean",
          "title" : "Is Dynamic Port"
        },
        "partitionRequirement" : {
          "propertyOrder" : 5,
          "nullable" : true,
          "oneOf" : [ {
            "$ref" : "#/definitions/HashPartition"
          }, {
            "$ref" : "#/definitions/RangePartition"
          }, {
            "$ref" : "#/definitions/SinglePartition"
          }, {
            "$ref" : "#/definitions/BroadcastPartition"
          }, {
            "$ref" : "#/definitions/UnknownPartition"
          } ],
          "title" : "Partition Requirement"
        },
        "dependencies" : {
          "propertyOrder" : 6,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "$ref" : "#/definitions/Object"
          },
          "title" : "Dependencies"
        }
      },
      "required" : [ "allowMultiInputs", "isDynamicPort" ]
    },
    "HashPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "hash" ],
          "default" : "hash",
          "options" : {
            "hidden" : true
          }
        },
        "hashAttributeNames" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "type" : "string"
          },
          "title" : "Hash Attribute Names"
        }
      },
      "title" : "hash",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "hash"
        }
      }
    },
    "RangePartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "range" ],
          "default" : "range",
          "options" : {
            "hidden" : true
          }
        },
        "rangeAttributeNames" : {
          "propertyOrder" : 1,
          "nullable" : true,
          "type" : "array",
          "items" : {
            "type" : "string"
          },
          "title" : "Range Attribute Names"
        },
        "rangeMin" : {
          "propertyOrder" : 2,
          "type" : "integer",
          "title" : "Range Min"
        },
        "rangeMax" : {
          "propertyOrder" : 3,
          "type" : "integer",
          "title" : "Range Max"
        }
      },
      "title" : "range",
      "required" : [ "type", "rangeMin", "rangeMax" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "range"
        }
      }
    },
    "SinglePartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "single" ],
          "default" : "single",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "single",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "single"
        }
      }
    },
    "BroadcastPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "broadcast" ],
          "default" : "broadcast",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "broadcast",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "broadcast"
        }
      }
    },
    "UnknownPartition" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "type" : {
          "type" : "string",
          "enum" : [ "none" ],
          "default" : "none",
          "options" : {
            "hidden" : true
          }
        }
      },
      "title" : "none",
      "required" : [ "type" ],
      "options" : {
        "multiple_editor_select_via_property" : {
          "property" : "type",
          "value" : "none"
        }
      }
    },
    "Object" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : { }
    }
  }
}

const schema2 = {
  type: "object",
  properties: {
    test: {
      type: "string",
      minLength : 1,
    },
  },
  required: ["test"],
};

// false
console.log(ajv.validate(schema2, json));

This demo shows the effect of adding @NotNull. After applying the first part solution, the bar chart operator is edited to have @NotNull. When adding the bar chart operator, the workflow is consistently invalid. However, without this requirement on the dot plot, the workflow changes to valid sometimes because these validations are passed due to empty string attributes (see debug screenshots above).

2025-08-25.14-48-53.mov

See also:

• fix: return error when attribute type is not set in UDF #3656
• required keyword for empty string ajv-validator/ajv#885

[AnzhiZhang]

The second part of this issue has been referenced in #3692.