-
Notifications
You must be signed in to change notification settings - Fork 104
fix(release): sync single node docker compose script with latest architecture #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@aicam Please review this PR. |
a49e4d9 to
22d68cb
Compare
d78e705 to
0a19fd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just had two concerns
| LAKEFS_STATS_ENABLED=1 | ||
| LAKEFS_DATABASE_TYPE=postgres | ||
| LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@texera-postgres:5432/texera_lakefs?sslmode=disable | ||
| LAKEFS_DATABASE_POSTGRES_CONNECTION_STRING=postgres://texera:password@postgres:5432/texera_lakefs?sslmode=disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to remove texera from all variables?
| # variables for example user, datasets and workflows | ||
| TEXERA_EXAMPLE_USERNAME=texera | ||
| TEXERA_EXAMPLE_PASSWORD=texera | ||
| TEXERA_EXAMPLE_USERNAME="${USER_SYS_ADMIN_USERNAME}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the env should have examples and docker compose override them, here you are using system env inside .env file
Overview
This PR syncs the docker compose file of the single node architecture with the latest micro service architecture.
Changes
config-service,computing-unit-managing-serviceandy-websocket-serverto Docker Composerelease-1-1-0tag