Skip to content

Conversation

@xuang7
Copy link
Contributor

@xuang7 xuang7 commented Oct 3, 2025

Purpose

This PR fixes #3804 that the upload status panel behaved unexpectedly: when there were no queued/active uploads, the UI still rendered empty panels, which was confusing. This PR hides empty panels and restores the clear empty state.

Changes

  • Introduce a flag hasAnyActivity = queuedCount > 0 || activeCount > 0 || pendingChangesCount > 0
  • Conditionally render status panels:
    • Pending only when queuedCount > 0
    • Uploading only when activeCount > 0
    • Finished only when hasAnyActivity
  • Restore the empty state: when no activity, render <texera-dataset-staged-objects-list> outside the collapse so “No pending changes” is visible
  • Add a bottom divider beneath the staged list to improve visual separation (the previous [nzBorder] was removed to avoid overlapping with the vertical divider)

Demonstration

Datasets page:
main

Finished panel:

Collapsed Expanded (delete) Expanded (adds)
collapsed delete expand

Uploading files:

uploading.mov

Remove files:

remove.mov

@github-actions github-actions bot added the frontend Changes related to the frontend GUI label Oct 3, 2025
@xuang7 xuang7 marked this pull request as ready for review October 3, 2025 20:39
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aglinxinyuan aglinxinyuan merged commit 24ba25d into apache:main Oct 4, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve upload status panels and hide inactive sections

2 participants