fix(file-service): avoid manually constructing the Dataset object through parameters #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
changed the title
bobbai00
changed the title
|
Our common practice is to create an issue and use a PR to fix the issue. So please create an issue. It's also a good chance to check the PR #3812 and follow the new bug-report template to create the issue. |
bobbai00
changed the title
Added. Please check |
|
Thanks. Do you think a test case can be added? |
|
This is the correct approach. We should apply the same fix to all other instances, if any. |
Added. Please check |
bobbai00
force-pushed
the
fix/dataset-parameter-order
branch
from
28561ab to
fd311a3
Compare
|
@aicam Please review it first. |
Use createdDataset.into(classOf[Dataset]) to convert DatasetRecord to Dataset POJO instead of manually constructing with parameters to avoid non-deterministic parameter ordering issues. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
bobbai00
force-pushed
the
fix/dataset-parameter-order
branch
from
738d8eb to
d494008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createdDataset.into(classOf[Dataset])to convert DatasetRecord to Dataset POJO instead of manual constructorFixes #3821