refactor(config): remove user-sys enabled flag #3831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xiaozhen-default-user-sys # Conflicts: # core/amber/src/test/scala/edu/uci/ics/amber/engine/e2e/DataProcessingSpec.scala
github-actions
bot
added
frontend
# Conflicts: # core/config/src/main/resources/user-system.conf
aglinxinyuan
requested changes
Oct 7, 2025
|
@bobbai00 can review it first. |
Yicong-Huang
reviewed
Oct 9, 2025
...ow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala
Show resolved
Hide resolved
bobbai00
reviewed
Oct 9, 2025
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.spec.ts
Show resolved
Hide resolved
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.ts
Show resolved
Hide resolved
aglinxinyuan
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a successor of #3782. As the non-user system mode is no longer used or maintained, we can remove the flag to switch between user-system being enabled/disabled, and keep only the mode of user-system being enabled.
Content
user-sys.enabledflag, both in the frontend and backend.ExecutionResourceMappingin the backend as it is no longer needed.WorkflowCacheServicein the frontend as it is no longer needed.