feat: improve file-service Docker Compose file
#3834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the file-service Docker Compose configuration by modernizing the format, preventing container name conflicts, and enabling data persistence with named volumes.
- Removed deprecated
versionattribute from Docker Compose file - Updated all container names with
texera-lakefs-prefix to avoid conflicts - Replaced commented volume configurations with default named volumes for data persistence
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@bobbai00 Could you please review the PR? |
|
I have tested the migration process for developers suggested in the issue, and it works. |
|
@bobbai00 Please review it. After you approve it, we can merge it. |
|
@aicam Could you please approve the CI run? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
versionattributeresolves #3816