Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 12, 2025

In our current implementation, we used the core folder as the root of all services. When looking for the configuration of a service, we search from the core folder. This logic relies heavily on the core folder. This PR changes the behavior:

  1. We use TEXERA_HOME env variable to find the root of the Texera repo. All services/configures/files should be searched starting from this dir.
  2. When omitted, we use the current directory as the default working directory.

fixes #3871

@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 06:27
@github-actions github-actions bot added fix backend Anything related to backend services service labels Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors configuration path resolution to use the TEXERA_HOME environment variable instead of hardcoded relative paths. The change allows for more flexible deployment and configuration management by defaulting to the current working directory when TEXERA_HOME is not set.

  • Removes hardcoded workflowComputingUnitManagingServicePath utility from PathUtils
  • Updates computing unit managing service to dynamically resolve configuration paths using TEXERA_HOME

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
core/config/src/main/scala/org/apache/amber/util/PathUtils.scala Removes unused workflowComputingUnitManagingServicePath constant
computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala Replaces hardcoded path with dynamic resolution using TEXERA_HOME environment variable

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang self-assigned this Oct 12, 2025
@Yicong-Huang Yicong-Huang changed the title fix: use TEXEAR_HOME and default to current folder to find config fix: use TEXEAR_HOME and use the current working directory as the default value Oct 12, 2025
@chenlica chenlica changed the title fix: use TEXEAR_HOME and use the current working directory as the default value fix: use TEXEAR_HOME or the current directory as the default working directory Oct 12, 2025
@chenlica chenlica self-requested a review October 12, 2025 06:39
@Yicong-Huang Yicong-Huang merged commit dcc05d5 into main Oct 12, 2025
18 checks passed
@Yicong-Huang Yicong-Huang deleted the fix/use-texera-home-for-config branch October 12, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Anything related to backend services fix service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

services cannot find config file

2 participants