Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 12, 2025

According to the reorganization plan #3846, this PR moves core/file-service out to the root folder.
resolves #3858.

Copilot AI review requested due to automatic review settings October 12, 2025 06:56
@github-actions github-actions bot added dependencies Pull requests that update a dependency file backend Anything related to backend services service labels Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a reorganization plan to move service modules out of the core directory structure to the root level. The changes remove utility path methods from PathUtils and update service configurations to use direct path resolution instead.

Key changes:

  • Remove path utility methods for services that were moved out of core
  • Update service configuration paths to use direct Path.of() resolution
  • Update test file paths to reflect new directory structure

Reviewed Changes

Copilot reviewed 5 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workflow-compiling-service/src/test/scala/org/apache/texera/service/resource/WorkflowCompilationResourceSpec.scala Updates test resource file path to reflect moved service location
workflow-compiling-service/src/main/scala/org/apache/texera/service/WorkflowCompilingService.scala Replaces PathUtils usage with direct path resolution for configuration file
file-service/src/main/scala/org/apache/texera/service/FileService.scala Replaces PathUtils usage with direct path resolution and cleans up imports
core/config/src/main/scala/org/apache/amber/util/PathUtils.scala Removes path utility methods for services moved out of core
computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala Replaces PathUtils usage with direct path resolution for configuration file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang changed the base branch from main to chore/relocate-workflow-compiling-service October 12, 2025 06:56
@Yicong-Huang Yicong-Huang self-assigned this Oct 12, 2025
@chenlica chenlica self-requested a review October 12, 2025 06:58
@aglinxinyuan aglinxinyuan requested a review from bobbai00 October 12, 2025 07:24
@Yicong-Huang Yicong-Huang removed the dependencies Pull requests that update a dependency file label Oct 12, 2025
Base automatically changed from chore/relocate-workflow-compiling-service to main October 12, 2025 16:52
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 12, 2025
@Yicong-Huang Yicong-Huang enabled auto-merge (squash) October 12, 2025 16:57
@Yicong-Huang Yicong-Huang removed the dependencies Pull requests that update a dependency file label Oct 12, 2025
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Oct 12, 2025
@Yicong-Huang Yicong-Huang merged commit 7720eb4 into main Oct 12, 2025
11 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/relocate-file-service branch October 12, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Anything related to backend services dependencies Pull requests that update a dependency file service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move core/file-service to file-service

3 participants