-
Notifications
You must be signed in to change notification settings - Fork 104
chore: rename core/scripts to bin
#3877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes the codebase by moving core/scripts to the root directory and renaming it to bin, creating a centralized location for all executable scripts and binaries.
Key changes:
- Updated all references from
core/scriptstobinacross documentation, configuration, and code files - Removed deprecated path utility functions and replaced them with direct path construction
- Updated GitHub workflows, Docker configurations, and labeler rules to reflect the new structure
Reviewed Changes
Copilot reviewed 17 out of 100 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workflow-compiling-service/src/test/scala/org/apache/texera/service/resource/WorkflowCompilationResourceSpec.scala | Updated file path reference in test |
| workflow-compiling-service/src/main/scala/org/apache/texera/service/WorkflowCompilingService.scala | Replaced path utility with direct path construction |
| pyright-language-service/package.json | Fixed package name from "pyright-language-server" to "pyright-language-service" |
| frontend/src/app/dashboard/type/dashboard-file.interface.ts | Updated documentation reference to new bin location |
| file-service/src/main/scala/org/apache/texera/service/FileService.scala | Replaced path utility with direct path construction |
| deployment/single-node/docker-compose.yml | Updated Docker volume mount path |
| core/dao/src/test/scala/org/apache/texera/dao/MockTexeraDB.scala | Updated SQL file path reference |
| core/config/src/main/scala/org/apache/amber/util/PathUtils.scala | Removed deprecated service path utilities |
| Multiple resource files | Updated documentation comments to reference new bin location |
| config-service/src/main/scala/org/apache/texera/service/ConfigService.scala | Replaced path utility with direct path construction |
| computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala | Replaced path utility with direct path construction |
| .github/workflows/github-action-build.yml | Updated CI script paths |
| .github/labeler.yml | Updated labeling rules for new directory structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
…me-core-scripts-to-bin
According to the reorganization plan #3846. This PR moves
core/scriptsout to the root directory, and renames it tobin. This folder will contain all executable scripts and binaries.resolves #3862