Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

@Yicong-Huang Yicong-Huang commented Oct 12, 2025

According to the reorganization plan #3846. This PR moves core/scripts out to the root directory, and renames it to bin. This folder will contain all executable scripts and binaries.

resolves #3862

@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 16:53
@github-actions github-actions bot added engine dependencies Pull requests that update a dependency file ddl-change Changes to the TexeraDB DDL frontend Changes related to the frontend GUI ci changes related to CI docs Changes related to documentations backend Anything related to backend services build service labels Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the codebase by moving core/scripts to the root directory and renaming it to bin, creating a centralized location for all executable scripts and binaries.

Key changes:

  • Updated all references from core/scripts to bin across documentation, configuration, and code files
  • Removed deprecated path utility functions and replaced them with direct path construction
  • Updated GitHub workflows, Docker configurations, and labeler rules to reflect the new structure

Reviewed Changes

Copilot reviewed 17 out of 100 changed files in this pull request and generated no comments.

Show a summary per file
File Description
workflow-compiling-service/src/test/scala/org/apache/texera/service/resource/WorkflowCompilationResourceSpec.scala Updated file path reference in test
workflow-compiling-service/src/main/scala/org/apache/texera/service/WorkflowCompilingService.scala Replaced path utility with direct path construction
pyright-language-service/package.json Fixed package name from "pyright-language-server" to "pyright-language-service"
frontend/src/app/dashboard/type/dashboard-file.interface.ts Updated documentation reference to new bin location
file-service/src/main/scala/org/apache/texera/service/FileService.scala Replaced path utility with direct path construction
deployment/single-node/docker-compose.yml Updated Docker volume mount path
core/dao/src/test/scala/org/apache/texera/dao/MockTexeraDB.scala Updated SQL file path reference
core/config/src/main/scala/org/apache/amber/util/PathUtils.scala Removed deprecated service path utilities
Multiple resource files Updated documentation comments to reference new bin location
config-service/src/main/scala/org/apache/texera/service/ConfigService.scala Replaced path utility with direct path construction
computing-unit-managing-service/src/main/scala/org/apache/texera/service/ComputingUnitManagingService.scala Replaced path utility with direct path construction
.github/workflows/github-action-build.yml Updated CI script paths
.github/labeler.yml Updated labeling rules for new directory structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Yicong-Huang Yicong-Huang changed the base branch from main to chore/relocate-pyright-language-server October 12, 2025 16:54
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Oct 12, 2025
@github-actions github-actions bot removed docs Changes related to documentations service labels Oct 12, 2025
Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
Base automatically changed from chore/relocate-pyright-language-server to main October 12, 2025 17:36
@Yicong-Huang Yicong-Huang enabled auto-merge (squash) October 12, 2025 18:11
@chenlica chenlica self-requested a review October 12, 2025 18:12
@Yicong-Huang Yicong-Huang removed engine ddl-change Changes to the TexeraDB DDL frontend Changes related to the frontend GUI ci changes related to CI backend Anything related to backend services labels Oct 12, 2025
@Yicong-Huang Yicong-Huang merged commit 984d631 into main Oct 12, 2025
19 of 20 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/rename-core-scripts-to-bin branch October 12, 2025 18:29
@Yicong-Huang Yicong-Huang self-assigned this Oct 13, 2025
Yicong-Huang added a commit that referenced this pull request Oct 13, 2025
There is a duplicated file being retained from #3877. This PR removes
it.

follows up on #3862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

move and rename core/scripts to bin

2 participants