Skip to content

chore: rename core to common #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 13, 2025
Merged

chore: rename core to common #3882

merged 10 commits into from
Oct 13, 2025

Conversation

@Yicong-Huang
Copy link
Contributor

According to the reorganization plan #3846. This PR renames core out to common. The folder will contain shared dependencies of services.

resolves #3861

Copilot AI review requested due to automatic review settings October 12, 2025 23:26
@github-actions github-actions bot added dependencies Pull requests that update a dependency file ddl-change Changes to the TexeraDB DDL python frontend Changes related to the frontend GUI ci changes related to CI docs Changes related to documentations build service labels Oct 12, 2025

This comment was marked as outdated.

Sign in to view

@Yicong-Huang Yicong-Huang removed dependencies Pull requests that update a dependency file ddl-change Changes to the TexeraDB DDL python frontend Changes related to the frontend GUI docs Changes related to documentations service labels Oct 12, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file ddl-change Changes to the TexeraDB DDL python frontend Changes related to the frontend GUI docs Changes related to documentations service labels Oct 12, 2025
@Yicong-Huang Yicong-Huang force-pushed the chore/rename-core-to-common branch from 7e77355 to 2eebba7 Compare October 12, 2025 23:41
@github-actions github-actions bot removed ddl-change Changes to the TexeraDB DDL python frontend Changes related to the frontend GUI docs Changes related to documentations build service labels Oct 12, 2025
@Yicong-Huang Yicong-Huang force-pushed the chore/rename-core-to-common branch from 12babfe to 8ae4488 Compare October 12, 2025 23:55
@aglinxinyuan aglinxinyuan requested a review from Copilot October 13, 2025 00:29
Copilot AI reviewed Oct 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 440 changed files in this pull request and generated 1 comment.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

aglinxinyuan
aglinxinyuan approved these changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally. Please check the latest Copilot comment.

@aglinxinyuan
Copy link
Contributor

Test case fixed.

@Yicong-Huang Yicong-Huang self-assigned this Oct 13, 2025
@Yicong-Huang Yicong-Huang removed the dependencies Pull requests that update a dependency file label Oct 13, 2025
@Yicong-Huang Yicong-Huang merged commit c1d6e11 into main Oct 13, 2025
11 checks passed
@Yicong-Huang Yicong-Huang deleted the chore/rename-core-to-common branch October 13, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes

Copilot code review Copilot Copilot left review comments

Assignees

@Yicong-Huang Yicong-Huang

Labels

ci changes related to CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rename core to common

2 participants

@Yicong-Huang @aglinxinyuan