fix: use TEXERA_HOME for jooq
#3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
ddl-change
github-actions
bot
removed
engine
ddl-change
There was a problem hiding this comment.
Pull Request Overview
This PR updates file references to use TEXERA_HOME environment variable for jooq configuration and normalizes SQL file paths throughout the codebase.
- Updated jooq code generator to use
TEXERA_HOMEfor locating configuration files - Replaced
bin/sql/path references withsql/across documentation and code comments - Modified CI workflow to use updated SQL file paths
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| common/dao/src/main/scala/org/apache/texera/dao/JooqCodeGenerator.scala | Modified to use TEXERA_HOME environment variable for finding jooq and storage configurations |
| common/dao/src/test/scala/org/apache/texera/dao/MockTexeraDB.scala | Updated SQL DDL path reference from bin/sql/ to sql/ |
| .github/workflows/github-action-build.yml | Updated CI workflow to use sql/ path instead of bin/sql/ for database setup |
| frontend/src/app/dashboard/type/dashboard-file.interface.ts | Updated comment reference to SQL file path |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowVersionResource.scala | Updated comment reference to SQL file path |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala | Updated comment reference to SQL file path |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/project/ProjectResource.scala | Updated comment reference to SQL file path |
| amber/src/main/scala/org/apache/texera/web/resource/dashboard/UnifiedResourceSchema.scala | Updated comment reference to SQL file path |
| amber/src/main/scala/org/apache/texera/web/resource/UserConfigResource.scala | Updated comment reference to SQL file path |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
common/dao/src/main/scala/org/apache/texera/dao/JooqCodeGenerator.scala
Outdated
Show resolved
Hide resolved
…tor.scala Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
Yicong-Huang
changed the title
TEXERA_HOME for jooq
aglinxinyuan
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets jooq use
TEXERA_HOMEto find configurations.