fix: make sub-string name search feature in admin dashboard case-insensitive #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the admin dashboard's user search functionality to perform case-insensitive name matching. Previously, the search required exact case matches; now it converts both the search query and user names to lowercase before comparison.
Key Changes:
- Modified the
searchByName()method to normalize search input and user names to lowercase - Replaced
indexOf()withincludes()for cleaner string matching - Added trimming of search input to handle leading/trailing whitespace
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aicam
reviewed
Oct 17, 2025
frontend/src/app/dashboard/component/admin/user/admin-user.component.ts
Outdated
Show resolved
Hide resolved
jaeyun0503
changed the title
auto-merge was automatically disabled
October 20, 2025 18:18
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR makes the sub-string search feature on user's name in admin dashboard case-insensitive.
Any related issues, documentation, discussions?
Fixes PR #1813
How was this PR tested?
Test case not introduced.
Was this PR authored or co-authored using generative AI tooling?
No.