TEZ-4387: use new doclet API in Java 9+ #187
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
tez-tools/pom.xml
Outdated
| <id>jdk9plus</id> | ||
| <activation> | ||
| <!-- JDK9 starts strong encapsulation of Java internals, JDK17 removes/hides those --> | ||
| <jdk>[9,9999)</jdk> |
There was a problem hiding this comment.
which version does this expression target?
if every version starting with "9", then a simply "9" should work
https://maven.apache.org/guides/introduction/introduction-to-profiles.html
The following configuration will trigger the profile when the JDK's version starts with "1.4" (eg. "1.4.0_08", "1.4.2_07", "1.4"):
<profiles>
<profile>
<activation>
<jdk>1.4</jdk>
</activation>
...
</profile>
</profiles>
There was a problem hiding this comment.
This is a range of versions, based on https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html I wanted to write for JDK version 9 and up:
<jdk>[9,)</jdk>
It also could be 17 and up as only 17 enforces the new API.
|
left some comments |
|
|
||
| @Override | ||
| public String getName() { | ||
| return "Example"; |
There was a problem hiding this comment.
where is this name used? is there a chance for a better name?
in case of no idea, I guess "Tez" would make do :)
There was a problem hiding this comment.
It's from the JDK sample code. I had to implement the method. Good catch, I totally forgot to update it for the current project.
|
It seems that in JDK 11 the documentation generation is quite buggy, which is a known issue and fixed in JDK 13. With Java 17 the documentation was generated successfully and believable, so I go further with the JDK17-only version. |
LA-Toth
force-pushed
the
a/TEZ-4387
branch
2 times, most recently
from
24860be
to
cd507aa
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@LA-Toth: is there any pending work on this PR I can help with? |
|
I had only one problem, the tests are too strict and cannot handle properly my solution. So I always get -1 for something. I don't think it's an error in my PR, I can't do anything. |
|
okay thanks, let me take a look next week |
LA-Toth
force-pushed
the
a/TEZ-4387
branch
2 times, most recently
from
e0a4723
to
618422d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
It works with JDK 11, as I see, at least locally. I just missed the version bump in |
|
💔 -1 overall
This message was automatically generated. |
|
this is strange, I wanted to test by building locally, but I can see that in jdk8 the problematic module is not included at all: I expected tez-javadoc-tools-base-jdk8 to be included |
No description provided.