-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4508: Allow the FAIR_PARALLELISM mode to accept multiple source vertices #306
Conversation
throw new TezUncheckedException( | ||
"Having more than one destination task process same partition(s) " + | ||
"only works with one bipartite source."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this assertion is not must because Tez users currently use FairShuffleVertexManager in specific cases on purpose.
I guess we need to add a new DataMovementType or new FairShuffleVertexManager for JOIN, but we don't immediately need it.
🎊 +1 overall
This message was automatically generated. |
While testing various cases, I found this might not work when amounts of unified vertices are uneven. I will close this one once. |
As explained in TEZ-4508, I expect there are valid use cases where FairShuffleVertexManager with FAIR_PARALLELISM should accept multiple SCATTER_GATHER edges.