-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEZ-4566: NPE in TezChild while fetching attemptId when container is asked to shut down #358
Conversation
💔 -1 overall
This message was automatically generated. |
this is a very weird edge case and I'm shocked we haven't bumped into it more often this patch is fine if you can double-check by manually running some UTs that are not running automatically here: tez-dag, tez-tests, can you please check that? also, can you please check if any of these log lines have been hit before this NPE:
tez/tez-dag/src/main/java/org/apache/tez/dag/app/TezTaskCommunicatorImpl.java Lines 411 to 416 in a1fcddb
according to the code, these should be hit on AM side, when we return with a ContainerTask.shouldDie == true |
One one of the LOG lines are there
And for same there is NPE
|
Ran the tests locally
tez-tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
No description provided.