THRIFT-5274: Enforce Java 8 compatibility #2325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enforce Java 8 compatibility using the new `--release` flag introduced in JDK9, so that all generated bytecode follows Java 8 strict compatibility, even when building with newer JDK versions (9 or later) (this fixes NoSuchMethodError with ByteBuffer, and other potential incompatibilities in bytecode generation that would make the code unable to run on a Java 8 JRE) * Also strictly enforce the JDK version used to build the project by ensuring it is at least version 1.8, and will fail fast when building the Java libraries if this condition is not met.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--releaseflag introducedin JDK9, so that all generated bytecode follows Java 8 strict
compatibility, even when building with newer JDK versions (9 or later)
(this fixes NoSuchMethodError with ByteBuffer, and other potential
incompatibilities in bytecode generation that would make the code
unable to run on a Java 8 JRE)
ensuring it is at least version 1.8, and will fail fast when building
the Java libraries if this condition is not met.
[skip ci]anywhere in the commit message to free up build resources.