Unsafe i32 to usize conversion from network data #2788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the problem with uncheckd data
conversion read from the network. Currently, code
reads data from the network, converts it to
i32, and then blindly converts it to usize (so -1
gets converted to -1_usize and causes panic in
debug build and huge memory use in release build).
This could easily become a security vulnerability.
The fix replaces all
as usize
casts to try_intostyle casts.
[skip ci]
anywhere in the commit message to free up build resources.