Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java remove spotless GitHub actions #3020

Closed
wants to merge 3 commits into from
Closed

Java remove spotless GitHub actions #3020

wants to merge 3 commits into from

Conversation

fishy
Copy link
Member

@fishy fishy commented Aug 14, 2024

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

fishy and others added 3 commits August 14, 2024 13:32
@fishy @emmenlau
Fix failed java build
a1a1481 
I think this was a bug from d4503a1.

Co-Authored-By: Mario Emmenlauer <mario@emmenlauer.de>
@fishy
Remove spotlessCheck step from github actions
384cdeb 
See discussion at:
https://lists.apache.org/thread/snkolv4skbk5hzotp2c7o4w8jj3n44j5.
@fishy
go: Fix cross test server
c71d8ae 
Client: go

This was a bug introduced by 91565d4
that broke go's cross-test server, but because other CI issues we didn't
run cross-test so we didn't notice the issue.
@fishy fishy force-pushed the java-remove-spotless-github-actions branch from 8fd6726 to c71d8ae Compare August 14, 2024 21:22
ctubbsii
ctubbsii reviewed Aug 14, 2024
View reviewed changes
Copy link
Member

@ctubbsii ctubbsii left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm strongly against removing spotless for the reasons mentioned in the linked thread. https://lists.apache.org/thread/snkolv4skbk5hzotp2c7o4w8jj3n44j5

@fishy fishy closed this Aug 16, 2024
@fishy fishy deleted the java-remove-spotless-github-actions branch August 16, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishy @ctubbsii