Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(rust): Add release workflow for rust #3027

Closed
wants to merge 2 commits into from

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 21, 2024

This PR adds release workflow for rust which will do cargo publish while tagged.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 21, 2024

cc @Jens-G, Would you like to take a look, thanks!

To make this workflow work, we also need to set a new secret call CARGO_REGISTRY_TOKEN.

@fishy fishy added rust github_actions Pull requests that update GitHub Actions code labels Aug 21, 2024
@Jens-G
Copy link
Member

Jens-G commented Aug 22, 2024

LGTM but I have not really too much expertise with Rust, so a second pair of eyes is more than appreciated.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 28, 2024

LGTM but I have not really too much expertise with Rust, so a second pair of eyes is more than appreciated.

Hi, @Jens-G, it seems no one else has reviewed this yet. However, this workflow has been successfully used in many other projects. For example:

Would this be valuable for your review?

@jimexist
Copy link
Member

this CARGO_REGISTRY_TOKEN needs to be added to GitHub repo itself right? i as a committer would not be able to do that, it requires some admin role in the repo itself.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 28, 2024

this CARGO_REGISTRY_TOKEN needs to be added to GitHub repo itself right? i as a committer would not be able to do that, it requires some admin role in the repo itself.

Yes. We will need one of our PMC members to contact with the INFRA team to get it setup.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 30, 2024

@Jens-G
Copy link
Member

Jens-G commented Aug 31, 2024

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 1, 2024

issues.apache.org/jira/browse/INFRA-26083

Thank you, @Jens-G, for this!

@Jens-G Jens-G closed this in a32990d Sep 7, 2024
@Jens-G
Copy link
Member

Jens-G commented Sep 7, 2024

INFRA has added the token.

@Xuanwo
Copy link
Member Author

Xuanwo commented Sep 7, 2024

INFRA has added the token.

Thanks!

@Xuanwo Xuanwo deleted the add-release-rust-workflow branch September 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants