-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIKA-3381] Lock down the Tika environment in tika-helm #2
Conversation
Thanks @philipsoutham I am testing using k3d and on our test K8s deployment. Will report back here shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @philipsoutham any thoughts on my commentary?
Chart.yaml
Outdated
@@ -19,7 +19,7 @@ | |||
--- | |||
apiVersion: v2 | |||
name: tika | |||
version: "latest-full" | |||
version: "1.25" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most recent tika-docker version is 1.26.
I am kinda torn between this usage of both latest
and -full
.
I don't really like it but I am unsure as to how we should distinguish the vanilla tika-server
package within the tika-docker
artifact. My goal for tika-helm
was simply for the Chart to mimic tika-docker
versioning. Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lewismc, OK I can change that, I just put 1.25 as a WAG because according to the helm spec (https://helm.sh/docs/topics/charts/#the-chartyaml-file) it needs a SemVer 2 version (https://semver.org/) so the latest-full
value for version
was preventing helm from deploying. I'm not all that familiar with helm so I'm not sure what the best way to parameterize that for automation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... neither am I if I am honest ...!
Successfully deployed to our k8s cluster.
|
Dropping all kernel capabilities and not running as root user. This starts and seems to work loading the default page, but I would like to have a full test suite to make sure it doesn't break under the various parsing modes to be sure.