Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service annotations #20

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

aidanthewiz
Copy link
Contributor

This update allows users to specify custom annotations using the Helm values file. This is useful for configuring cloud-specific features like internal load balancers on AWS.

Example command to adjust annotations with this change:

helm upgrade tika ./tika-2.9.0.tgz --install -n tika \
  --set image.tag=2.9.0.0 \
  --set service.type=LoadBalancer \
  --set "service.annotations.service\.beta\.kubernetes\.io/aws-load-balancer-internal=\"true\"" \
  --set "service.annotations.service\.beta\.kubernetes\.io/aws-load-balancer-type=\"nlb\""

You can also adjust the values.yaml file manually instead of using --set.

This update allows users to specify custom annotations using the Helm values file. This is useful for configuring cloud-specific features like internal load balancers on AWS.
@lewismc
Copy link
Member

lewismc commented Apr 17, 2024

Hi @aidanthewiz thanks for the patch. I looked at it and it looks A OK. I’ll try to merge this week. 👍

@lewismc lewismc merged commit 5df056c into apache:main May 8, 2024
1 check passed
@lewismc
Copy link
Member

lewismc commented May 8, 2024

Thanks @aidanthewiz apologies for the delay.

kubectl describe service tika
Name:                     tika
Namespace:                tika-test
Labels:                   ...
Annotations:              meta.helm.sh/release-name: tika
                          meta.helm.sh/release-namespace: tika-test
                          service.beta.kubernetes.io/aws-load-balancer-internal: "true"
                          service.beta.kubernetes.io/aws-load-balancer-type: "nlb"
Selector:                 app.kubernetes.io/instance=tika,app.kubernetes.io/name=tika
Type:                     LoadBalancer
I...
Events:
  Type    Reason                Age   From                Message
  ----    ------                ----  ----                -------
  Normal  Type                  13m   service-controller  ClusterIP -> LoadBalancer
  Normal  EnsuringLoadBalancer  13m   service-controller  Ensuring load balancer
  Normal  AppliedDaemonSet      13m   service-controller  Applied LoadBalancer DaemonSet kube-system/svclb-tika-8f943644
  Normal  UpdatedLoadBalancer   13m   service-controller  Updated LoadBalancer with new IPs: [] -> ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants