Skip to content

Commit

Permalink
NSIS: Use "ReserveFile /plugin" instead of ReserveFile and copying DLLs.
Browse files Browse the repository at this point in the history
Checked with 11.0.5 that it doesn't change the installer exe.
  • Loading branch information
rainerjung committed Mar 6, 2025
1 parent 74e966e commit 9d61cbf
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
6 changes: 0 additions & 6 deletions build.properties.default
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,6 @@ nsis.bin.checksum.algorithm=MD5|SHA-1
nsis.bin.checksum.value=e3e2803a13ead75e4471a51069d04c20|22cf776b463c6c845444328341219167abf399dc
nsis.bin.home=${base.path}/nsis-${nsis.version}
nsis.executable.windows=${nsis.bin.home}/makensis.exe
nsis.arch.dir=x86-unicode/
nsis.installoptions.dll=${nsis.bin.home}/Plugins/${nsis.arch.dir}InstallOptions.dll
nsis.nsexec.dll=${nsis.bin.home}/Plugins/${nsis.arch.dir}nsExec.dll
nsis.nsisdl.dll=${nsis.bin.home}/Plugins/${nsis.arch.dir}NSISdl.dll
nsis.system.dll=${nsis.bin.home}/Plugins/${nsis.arch.dir}System.dll
nsis.nsdialogs.dll=${nsis.bin.home}/Plugins/${nsis.arch.dir}nsDialogs.dll
nsis.bin.loc=${base-sf.loc}/nsis/nsis-${nsis.version}.zip
nsis.src.checksum.algorithm=MD5|SHA-1
nsis.src.checksum.value=dec8094892b881f8bed0a170feee3200|d99f80a197653ad7a623a12f209853d68da1ab84
Expand Down
5 changes: 0 additions & 5 deletions build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2706,11 +2706,6 @@ You may need a custom build of makensis. Instructions for this may be found in B
<include name="*.xml"/>
</fileset>
</copy>
<copy file="${nsis.installoptions.dll}" todir="${tomcat.dist}"/>
<copy file="${nsis.nsexec.dll}" todir="${tomcat.dist}"/>
<copy file="${nsis.nsisdl.dll}" todir="${tomcat.dist}"/>
<copy file="${nsis.system.dll}" todir="${tomcat.dist}"/>
<copy file="${nsis.nsdialogs.dll}" todir="${tomcat.dist}"/>
<copy file="res/install-win/tomcat.nsi" tofile="${tomcat.dist}/tomcat.nsi" overwrite="true" encoding="ISO-8859-1">
<filterset refid="version.filters"/>
<filterset refid="path.filters"/>
Expand Down
4 changes: 2 additions & 2 deletions res/install-win/tomcat.nsi
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ Var ServiceInstallLog
!finalize 'ant -f @BASEDIR@/build.xml jsign-installer'
!uninstfinalize 'ant -f @BASEDIR@/build.xml -Dcodesigning.file_to_sign=%1 jsign-uninstaller'

ReserveFile System.dll
ReserveFile nsDialogs.dll
ReserveFile /plugin System.dll
ReserveFile /plugin nsDialogs.dll
ReserveFile tomcat-users_1.xml
ReserveFile tomcat-users_2.xml

Expand Down

0 comments on commit 9d61cbf

Please sign in to comment.