Skip to content

Commit

Permalink
Remove extra verify-callback (#7540)
Browse files Browse the repository at this point in the history
  • Loading branch information
shinrich authored May 5, 2021
1 parent 5b2113b commit f793976
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 1 deletion.
1 change: 0 additions & 1 deletion iocore/net/SSLClientUtils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,6 @@ SSLInitClientContext(const SSLConfigParams *params)
}
#endif

SSL_CTX_set_verify(client_ctx, SSL_VERIFY_PEER, verify_callback);
SSL_CTX_set_verify_depth(client_ctx, params->client_verify_depth);
if (SSLConfigParams::init_ssl_ctx_cb) {
SSLConfigParams::init_ssl_ctx_cb(client_ctx, false);
Expand Down
2 changes: 2 additions & 0 deletions tests/gold_tests/tls/tls_client_cert_override.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@
ts.addSSLfile("ssl/signed-bar.key")

ts.Disk.records_config.update({
'proxy.config.diags.debug.enabled': 1,
'proxy.config.diags.debug.tags': 'ssl',
'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.server.private_key.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.client.cert.path': '{0}'.format(ts.Variables.SSLDir),
Expand Down
2 changes: 2 additions & 0 deletions tests/gold_tests/tls/tls_verify_override.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@
# Case 1, global config policy=permissive properties=signature
# override for foo.com policy=enforced properties=all
ts.Disk.records_config.update({
'proxy.config.diags.debug.enabled': 1,
'proxy.config.diags.debug.tags': 'ssl',
'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.server.private_key.path': '{0}'.format(ts.Variables.SSLDir),
# set global policy
Expand Down
2 changes: 2 additions & 0 deletions tests/gold_tests/tls/tls_verify_override_base.test.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@
# Case 1, global config policy=permissive properties=signature
# override for foo.com policy=enforced properties=all
ts.Disk.records_config.update({
'proxy.config.diags.debug.enabled': 1,
'proxy.config.diags.debug.tags': 'ssl',
'proxy.config.ssl.server.cert.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.server.private_key.path': '{0}'.format(ts.Variables.SSLDir),
'proxy.config.ssl.client.CA.cert.path': '{0}'.format(ts.Variables.SSLDir),
Expand Down

0 comments on commit f793976

Please sign in to comment.