CID 1517813: Null pointer dereferences

[zwoop]

*** CID 1517813:  Null pointer dereferences  (REVERSE_INULL)
/proxy/http/[HttpSM.cc](http://httpsm.cc/): 1699 in HttpSM::create_server_session(NetVConnection *, MIOBuffer *, IOBufferReader *)()
1693       retval->attach_hostname(t_state.current.server->name);
1694       retval->new_connection(netvc, netvc_read_buffer, netvc_reader);
1695     
1696       ATS_PROBE1(new_origin_server_connection, t_state.current.server->name);
1697       retval->set_active();
1698     
   CID 1517813:  Null pointer dereferences  (REVERSE_INULL)
   Null-checking "netvc" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1699       if (netvc) {
1700         ats_ip_copy(&t_state.server_info.src_addr, netvc->get_local_addr());
1701       }
1702     
1703       // If origin_max_connections or origin_min_keep_alive_connections is set then we are metering
1704       // the max and or min number of connections per host. Transfer responsibility for this to the

[zwoop]

A guess, this may be introduced from #9869.

[JosiahWI]

This was introduced from #9482 I think. Doing a dynamic_cast on a nullptr must not cause Coverity to complain, but it was changed from a dynamic_cast to a method call on the netvc object.