CID 1517812: Performance inefficiencies

[zwoop]

*** CID 1517812:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/iocore/net/[UnixUDPNet.cc](http://unixudpnet.cc/): 97 in UDPPacket::new_incoming_UDPPacket(sockaddr *, sockaddr *, Ptr<IOBufferBlock>)()
91     
92       p->p.in_the_priority_queue = 0;
93       p->p.in_heap               = 0;
94       p->p.delivery_time         = 0;
95       ats_ip_copy(&p->from, from);
96       ats_ip_copy(&p->to, to);
   CID 1517812:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
   "block" is copied in a call to copy assignment "operator =", when it could be moved instead.
97       p->p.chain = block;
98     
99       return p;
100     }
101     
102     UDPPacket::UDPPacket()

[zwoop]

Making a bit of a guess, but this may be coming in from #9905 or #9869.

[JosiahWI]

I took a look at it, and it looks like this was directly introduced by #9413.

[JosiahWI]

Sorry, looked at that and that wasn't the issue. It was #9905. The pointer was passed by reference and now it's passed by value.

[brbzull0]

Just saw this. will take a look.