Skip to content

Core plugins are setting pcre_malloc and pcre_free. #7475

@ywkaras

Description

@ywkaras
wkaras ~/REPOS/TS
M$ grep 'pcre_malloc *=' $(findsrc)
./plugins/regex_revalidate/regex_revalidate.c:  pcre_malloc = &ts_malloc;
./plugins/experimental/cookie_remap/cookie_remap.cc:  pcre_malloc = &ink_malloc;
./plugins/regex_remap/regex_remap.cc:  pcre_malloc = &ts_malloc;
./src/traffic_server/traffic_server.cc:  pcre_malloc = ats_malloc;
wkaras ~/REPOS/TS
M$ grep 'pcre_free *=' $(findsrc)
./plugins/regex_revalidate/regex_revalidate.c:  pcre_free   = &ts_free;
./plugins/experimental/cookie_remap/cookie_remap.cc:  pcre_free   = &ink_free;
./plugins/regex_remap/regex_remap.cc:  pcre_free   = &ts_free;
./src/traffic_server/traffic_server.cc:  pcre_free   = ats_free;
wkaras ~/REPOS/TS
M$

This is probably just a cosmetic problem. But, generally, plugins should not assume they are exclusively using global variables they don't define.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions