Skip to content

Fix missing PCRE includes in CMake by linking to tscore #10073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bneradt merged 5 commits into from
Jul 21, 2023
Merged

Fix missing PCRE includes in CMake by linking to tscore #10073

bneradt merged 5 commits into from
Jul 21, 2023

Conversation

@JosiahWI
Copy link
Contributor

@JosiahWI JosiahWI commented Jul 20, 2023 •
edited
Loading

This is a step towards getting the dependency tree fixed. And it fixes the missing pcre includes.

@JosiahWI JosiahWI self-assigned this Jul 20, 2023
@JosiahWI JosiahWI added the CMake work related to CMakes scripts or issues label Jul 20, 2023
@JosiahWI JosiahWI added this to the 10.0.0 milestone Jul 20, 2023
@JosiahWI JosiahWI marked this pull request as draft July 20, 2023 21:22
@JosiahWI JosiahWI marked this pull request as ready for review July 20, 2023 21:40
@JosiahWI JosiahWI changed the title Add transitive PCRE deps to lots of targets Fix missing PCRE includes in CMake by linking to tscore Jul 20, 2023
moonchen
moonchen previously approved these changes Jul 20, 2023
View reviewed changes
JosiahWI and others added 5 commits July 21, 2023 11:35
@JosiahWI
Add transitive PCRE deps to lots of targets
09ee25d 
This fixes all the PCRE include errors I have noticed on Mac.
@JosiahWI
Link everything that needs tscore to tscore
490f275 
This is a step towards getting the dependency tree fixed. And it
fixes the missing pcre includes.
@moonchen @JosiahWI
Fix build on macOS
5712ff8 
- Use -undefined dynamic_lookup to ignore unresolved dependencies which are located inside traffic_server
- Add some missing dependencies
- Break a cyclic dependency between tscppapi and tscore
@moonchen @JosiahWI
Use target_link_options instead of LINK_FLAGS
7ad5dfb
@moonchen @JosiahWI
Fix indentation
c7074e8
@JosiahWI
Copy link
Contributor Author

JosiahWI commented Jul 21, 2023

Rebased on master.

@JosiahWI
Copy link
Contributor Author

JosiahWI commented Jul 21, 2023 •
edited
Loading

Confirmed this repairs the CMake build on Mac by compiling ATS and running the Catch tests with this patch.

@bneradt bneradt merged commit 5bf3ec2 into apache:master Jul 21, 2023
@JosiahWI JosiahWI deleted the fix/cmake-pcre branch July 21, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moonchen moonchen moonchen approved these changes

Assignees

@JosiahWI JosiahWI

Labels

CMake work related to CMakes scripts or issues

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JosiahWI @moonchen @bneradt