Skip to content

Remove legacy IntrusiveDList #10106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SolidWallOfCode merged 1 commit into from
Jul 27, 2023
Merged

Remove legacy IntrusiveDList #10106

SolidWallOfCode merged 1 commit into from
Jul 27, 2023

Conversation

@SolidWallOfCode
Copy link
Member

@SolidWallOfCode SolidWallOfCode commented Jul 27, 2023

No description provided.

@SolidWallOfCode SolidWallOfCode added this to the 10.0.0 milestone Jul 27, 2023
@SolidWallOfCode SolidWallOfCode self-assigned this Jul 27, 2023
@SolidWallOfCode SolidWallOfCode changed the title Swoc intrusive dlist Remove legacy IntrusiveDList Jul 27, 2023
ywkaras
ywkaras reviewed Jul 27, 2023
View reviewed changes
doc/developer-guide/internal-libraries/MemArena.en.rst Outdated
Copy link
Contributor

@ywkaras ywkaras Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Sphinx only likes this the first time it's used: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/2470/Sphinx_20Docs/developer-guide/internal-libraries/MemArena.en.html#memarena

Copy link
Member Author

@SolidWallOfCode SolidWallOfCode Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying problem is the class data is populated by other document files, in this particular case by "intrusive_dlist.en.rst" which no longer exists.

Copy link
Contributor

@ywkaras ywkaras Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change doesn' t look any better to me: https://ci.trafficserver.apache.org/job/Github_Builds/job/docs/2472/Sphinx_20Docs/developer-guide/internal-libraries/MemArena.en.html#memarena . But anyway.

Copy link
Contributor

@ywkaras ywkaras Jul 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The curse of Sphinx is inescapable.

ywkaras
ywkaras previously approved these changes Jul 27, 2023
View reviewed changes
@SolidWallOfCode SolidWallOfCode merged commit 5d0a549 into apache:master Jul 27, 2023
@bneradt bneradt mentioned this pull request Sep 20, 2023
Closed
bneradt added a commit to bneradt/trafficserver that referenced this pull request Jul 12, 2024
@bneradt
YTSATS-4260: Revert libswoc IntrusiveHashMap (apache#853)
8e1053c 
Revert "libswoc: Update IntrusiveHashMap in HTTP session manager. (apache#9872)"

apache#9872

This reverts commit ca4f8cd.

I'm reverting this IntrusiveHashMap switch to libswoc because it
introduces a spike in our origin side connections.

The following is also reverted to add back the IntrusiveHashMap
and IntrusiveDList implementations:

Revert "libswoc: Remove legacy IntrusiveHashMap (apache#10104)"

This reverts commit 5706e3b.

Revert "libswoc: Remove legacy IntrusiveDList. (apache#10106)"

This reverts commit 5d0a549.

Co-authored-by: bneradt <bneradt@yahooinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywkaras ywkaras ywkaras approved these changes

Assignees

@SolidWallOfCode SolidWallOfCode

Labels

Cleanup CPP API CPP Util

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@SolidWallOfCode @ywkaras