TS-4861: Turn ECONNRESET into an end-of-file. #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do traffic_ctl server restart, then traffic_manager is getting an ECONNRESET error on the management socket after traffic_server exits. traffic_manager takes this as a fatal error and exits too. The fix is to turn ECONNRESET into an EOF (0) return from mgmt_read_pipe() so that traffic_manager correctly sees that traffic_server has gone away.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/796/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/692/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/797/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/693/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/798/ for details. |
Contributor
|
Please test on docs, cursory code review looks good. 👍 |
Contributor
Author
|
This is running on |
Contributor
|
👍 - Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do traffic_ctl server restart, then traffic_manager is getting
an ECONNRESET error on the management socket after traffic_server
exits. traffic_manager takes this as a fatal error and exits too.
The fix is to turn ECONNRESET into an EOF (0) return from
mgmt_read_pipe() so that traffic_manager correctly sees that
traffic_server has gone away.