Strictly follow Content-Length header ABNF rule #10144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
reviewed
Aug 3, 2023
- Replace content-length value type from const char * to std::string_view
jpeach
approved these changes
Aug 7, 2023
Contributor
jpeach
left a comment
jpeach
left a comment
There was a problem hiding this comment.
Looks good. Would you mind making a follow-up PR to remove the non-sotringview version of value_get?
Contributor
Author
|
I'll file an issue to deprecate the |
Contributor
|
@masaori335 This has a small merge conflict for 9.2.x, can you make a branch PR please? |
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Aug 13, 2023
- Replace content-length value type from const char * to std::string_view (cherry picked from commit f9aa1e0) Conflicts: proxy/hdrs/unit_tests/test_Hdrs.cc
zwoop
pushed a commit
that referenced
this pull request
Aug 14, 2023
masaori335
added a commit
to masaori335/trafficserver
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #10137.
RFC 9110 8.6. Content-Length
If the value filed is empty, it should be handled as a malformed header.