Fixes a problem which can decrement milestone metrics unintentionally #10188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
[approve ci autest] |
bryancall
approved these changes
Aug 15, 2023
Contributor
Author
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Sep 26, 2023
…apache#10188) (cherry picked from commit 583318a)
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Upgrade yaml-cpp version to 0.8.0 (apache#10249) This dependency is not needed, cmake did it right (apache#10250) Revert "Make OSX and FreeBSD not required temporarily (apache#10237)" (apache#10248) Python 3.12: microserver.test.ext wrap_socket update (apache#10247) Coverity 1508984: Dereference null return value (apache#10245) fall back to configure file for older cmake versions (apache#10236) TLS early data: logging updates (apache#10115) Fixing TSHttpTxnServerAddrSet (apache#10189) Make OSX and FreeBSD not required temporarily (apache#10237) Fixes a problem which can decrement milestone metrics unintentionally (apache#10188) Fix editor config for makefiles. (apache#10190) Correctly handle encoding for cache hash generation (apache#10126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe what can happen here is that if a milestone is 0 (because it never triggered), we will decrement that metric with 1. This often has little impact, because of other transaction adding hundreds if not thousands of msec to those milestone metrics. An example when this happens is when you have cache misses, and the server connection milestones are all 0.