fix(http): do reverse dns resolution only for IP addresses #10234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih-acar
force-pushed
the
fix_reverse_dns_origin
branch
from
1dc30ec to
5126f61
Compare
Contributor
|
[approve ci autest] |
Member
|
All of my comments are really "don't use ink_net if you can avoid it". The libswoc IP library should be used instead. |
We might use an origin fqdn starting with a number. Thus a reverse dns resolution is requested for a FQDN, which is failing and adding latency penalty in our test bed (around 20 ms per request). Refactor some IP checks and use the swoc::IPAddr to determine if the origin is an IP address. Signed-off-by: Fatih Acar <facar@scaleway.com>
fatih-acar
force-pushed
the
fix_reverse_dns_origin
branch
from
5126f61 to
49e3ea2
Compare
Member
|
[approve ci] |
SolidWallOfCode
approved these changes
Sep 25, 2023
Member
|
Trying to catch up - approved. Thank you for all of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might use an origin fqdn starting with a number. Thus a reverse dns resolution is requested for a FQDN, which is failing and adding latency penalty in our test bed (around 20 ms per request). Refactor some IP checks and use the swoc::IPAddr to determine if the origin is an IP address.