Skip to content

Check the inet_pton return value for IP reputations #10267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Aug 28, 2023
Merged

Check the inet_pton return value for IP reputations #10267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions plugins/experimental/rate_limit/ip_reputation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,24 @@ SieveLru::hasher(const std::string &ip, u_short family) // Mostly a convenience
case AF_INET: {
sockaddr_in sa4;

inet_pton(AF_INET, ip.c_str(), &(sa4.sin_addr));
sa4.sin_family = AF_INET;
return hasher(reinterpret_cast<const sockaddr *>(&sa4));
if (inet_pton(AF_INET, ip.c_str(), &(sa4.sin_addr))) {
sa4.sin_family = AF_INET;
return hasher(reinterpret_cast<const sockaddr *>(&sa4));
}
} break;
case AF_INET6: {
sockaddr_in6 sa6;

inet_pton(AF_INET6, ip.c_str(), &(sa6.sin6_addr));
sa6.sin6_family = AF_INET6;
return hasher(reinterpret_cast<const sockaddr *>(&sa6));
if (inet_pton(AF_INET6, ip.c_str(), &(sa6.sin6_addr))) {
sa6.sin6_family = AF_INET6;
return hasher(reinterpret_cast<const sockaddr *>(&sa6));
}
} break;
default:
// Really shouldn't happen ...
return 0;
break;
}

return 0; // Probably can't happen, but have to return something
}
// Constructor, setting up the pre-sized LRU buckets etc.
SieveLru::SieveLru(uint32_t num_buckets, uint32_t size) : _lock(TSMutexCreate())
Expand Down