Skip to content

Fix slice head request memory issue #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serrislew merged 2 commits into from
Sep 6, 2023
Merged

Fix slice head request memory issue #10285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c22749d
Fix slice head request memory issue
Aug 25, 2023
ce3c9f2
conditional syntax
Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/experimental/slice/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,8 +668,10 @@ handle_server_resp(TSCont contp, TSEvent event, Data *const data)
data->m_blocknum = firstblock;
}

// continue processing blocks?
if (data->m_req_range.blockIsInside(data->m_config->m_blockbytes, data->m_blocknum)) {
// continue processing blocks if more requests need to be made
// HEAD requests only has one slice block
if (data->m_req_range.blockIsInside(data->m_config->m_blockbytes, data->m_blocknum) &&
data->m_config->m_method_type != TS_HTTP_METHOD_HEAD) {
// Don't immediately request the next slice if the client
// isn't keeping up

Expand All @@ -682,13 +684,11 @@ handle_server_resp(TSCont contp, TSEvent event, Data *const data)
int64_t const threshout = data->m_config->m_blockbytes;
int64_t const buffered = output_sent - output_done;

// for PURGE requests, clients won't request more data (no body content)
if (threshout < buffered && !data->m_config->onlyHeader()) {
start_next_block = false;
DEBUG_LOG("%p handle_server_resp: throttling %" PRId64, data, buffered);
}
} else if (!data->m_config->onlyHeader()) {
// client doesn't need to accept server response for PURGE requests
start_next_block = false;
}
if (start_next_block) {
if (!request_block(contp, data)) {
Expand Down