Skip to content

Preserve unmapped url regardless of need for remapping #10304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 1 commit into from
Sep 11, 2023
Merged

Preserve unmapped url regardless of need for remapping #10304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions proxy/http/HttpSM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4363,9 +4363,6 @@ HttpSM::do_remap_request(bool run_inline)

check_sni_host();

// Preserve effective url before remap
t_state.unmapped_url.create(t_state.hdr_info.client_request.url_get()->m_heap);
t_state.unmapped_url.copy(t_state.hdr_info.client_request.url_get());
// Depending on a variety of factors the HOST field may or may not have been promoted to the
// client request URL. The unmapped URL should always have that promotion done. If the HOST field
// is not already there, promote it only in the unmapped_url. This avoids breaking any logic that
Expand Down
4 changes: 4 additions & 0 deletions proxy/http/HttpTransact.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,10 @@ HttpTransact::HandleBlindTunnel(State *s)
void
HttpTransact::StartRemapRequest(State *s)
{
// Preserve effective url before remap, regardless of actual need for remap
s->unmapped_url.create(s->hdr_info.client_request.url_get()->m_heap);
s->unmapped_url.copy(s->hdr_info.client_request.url_get());

if (s->api_skip_all_remapping) {
TxnDebug("http_trans", "API request to skip remapping");

Expand Down