Skip to content

Disable copying/moving for DbgCtl. #10321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywkaras merged 1 commit into from
Sep 5, 2023
Merged

Disable copying/moving for DbgCtl. #10321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/ts/DbgCtl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ class DbgCtl
static void print(char const *tag, char const *file, char const *function, int line, char const *fmt_str, ...)
TS_PRINTFLIKE(5, 6);

// No copying/moving.
DbgCtl(DbgCtl const &) = delete;
Copy link
Contributor

@jpeach jpeach Sep 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to delete DbgCtl(DbgCtl &&) these days?

Copy link
Contributor Author

@ywkaras ywkaras Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving defaults to whatever copying is: https://godbolt.org/z/cETc71dxr .

DbgCtl &operator=(DbgCtl const &) = delete;

private:
using _TagData = std::pair<char const *const, bool>;

Expand Down