Add TSVConnFdGet api #10324
Merged
Add TSVConnFdGet api #10324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
reviewed
Aug 31, 2023
| Description | ||
| ----------- | ||
| Returns the file descriptor associated with the SSL connection :arg:`sslp`. |
Member
There was a problem hiding this comment.
Why do we need to limit this just for SSL connection? Are we going to add TSVConnFdGet and TSVConnQuicFdGet if we needed? Plugins would need to call isSSL() and isQUIC() then call the corresponding TSVConnXFdGet()`. It doesn't sounds handy.
Member
Author
There was a problem hiding this comment.
Yeah, that crossed my mind as I pushed the branch up. Let me take a pass at generalizing.
maskit
reviewed
Sep 6, 2023
include/ts/ts.h
Outdated
| TSReturnCode TSVConnTunnel(TSVConn sslp); | ||
| /* Return the SSL object associated with the connection */ | ||
| TSSslConnection TSVConnSslConnectionGet(TSVConn sslp); | ||
| /* Return the file descriptoer associated with the ssl connection */ |
Member
|
The change looks almost fine, but I don't see API proposal for this on the list. |
zwoop
requested changes
Sep 7, 2023
|
|
||
| int | ||
| tsapi::c::TSVConnFdGet(TSVConn vconnp) | ||
| { |
Contributor
There was a problem hiding this comment.
It kinda feels that we should do the normal assertion on the vconnp here, rather than checking the nullptr after the casting. Like the common pattern is
sdk_assert(sdk_sanity_check_null_ptr((void *)vconnp) == TS_SUCCESS);
I guess I'm fine checking the vconnp explicitly as well, but probably should be done before the cast.
Member
Author
|
Sent the API email to the list a couple days ago. Will make a new PR with the remaining changes next week. |
bneradt
approved these changes
Sep 11, 2023
zwoop
approved these changes
Sep 11, 2023
bryancall
pushed a commit
that referenced
this pull request
Sep 29, 2023
(cherry picked from commit 7ddb721) Conflicts: include/ts/ts.h
bryancall
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit 7ddb721) Conflicts: include/ts/ts.h src/traffic_server/InkAPI.cc
bryancall
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit 7ddb721) Conflicts: include/ts/ts.h src/traffic_server/InkAPI.cc
traeak
pushed a commit
to traeak/trafficserver
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 7ddb721) Conflicts: include/ts/ts.h
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* commit '236b749b2b3cc746829ad534a7034ab7799d1b71': Allow origins to do TLS renegotiation (apache#10385) Remove deprecated debug output functions from 21 source files. (apache#9683) Fixes some make test build problems (apache#10402) Removes unused Errata functions from WCCP (apache#10380) Move InkAPI.cc into src/api (apache#10315) cmake: Generate files in rc, install the trafficserver script (apache#10367) Add support for OCSP requests by GET method (apache#10306) Preserve unmapped url regardless of need for remapping (apache#10304) Add TSVConnFdGet api (apache#10324) include/ts: comma on all last enum elements (apache#10400) cmake: Add remaining plugins without external deps (apache#10395) CID-1508974 (apache#10397) CID-1508987 (apache#10398) Coverity 1518564: fix off by one (apache#10401)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit 7ddb721) Conflicts: include/ts/ts.h src/traffic_server/InkAPI.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a convenience API for working with SSL connections.
This closes #10323