Skip to content

Coverity 1518612: Remove dead code #10384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serrislew merged 2 commits into from
Sep 7, 2023
Merged

Coverity 1518612: Remove dead code #10384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82425e2
Coverity 1518612: Remove dead code
Sep 7, 2023
82da981
ensure out_len is always > 0
Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/experimental/cookie_remap/strip.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ get_stripped(const char *in, ssize_t in_len, char *out, int *out_len, unsigned i
char *w, *out_end; /* where we write to, write limit */

/* validate params */
if (in == nullptr || in_len < 0 || out_len == nullptr || *out_len < 0 || (out == nullptr && *out_len > 0) ||
if (in == nullptr || in_len < 0 || out_len == nullptr || *out_len <= 0 || (out == nullptr && *out_len > 0) ||
(flags & (~allowed_flags))) {
if (out != nullptr && out_len != nullptr && *out_len > 0) {
*out = '\0';
Expand Down Expand Up @@ -228,7 +228,7 @@ get_stripped(const char *in, ssize_t in_len, char *out, int *out_len, unsigned i
retval = stripped_core(r, in_end, &w, out_end, flags);

/* null terminate */
out_end += out_end ? 1 : 0; /* undo decrement at start */
out_end++; /* undo decrement at start */
write_char_if_room(&w, out_end, '\0'); /* try to term at end of output */

/* report the required/used length */
Expand Down