URL.cc: url_length_get consider ipv6 address with added [] #10387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
approved these changes
Sep 8, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: Don't set port number as part of hostname (apache#10386) JSONRPC handler: Add check for the lifecycle hooks. (apache#10312) Removes all HostDB persistent storage (apache#10368) Restores the traffic_server option for --maxRecords (apache#10388) URL.cc: url_length_get consider ipv6 address with added [] (apache#10387) make alternate tests wait a multiple of cache_config_mutex_retry_delay (apache#10378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inside URL.cc url_string_get first calculates output url length, allocates space then calls url_print.
This fix copies the ipv6 address check and [ ] wrap from url_print to the url_length_get function.